In Settings/Your Name/iCloud, is Photos syncing turned on?
Consider getting a new ID and family Sharing.
Family Sharing -What types of content can I share?
Family Sharing - If you don‘t see your family‘s shared content
Family Sharing - purchases and payments
Family Sharing – share iCloud Storage