how come one of my messages shows green even tho the other user has an iphone.?

One possibility is that the other user is like me and has an iPhone but does not have Settings > Messages > iMessage turned on.

It means the other user has not enabled iMessage, or did not have an internet connection when you sent a message.