INeedHelpPlease🇬-1F1E7; wrote:
when i set up my new phone, can i log into my iCloud account on it then disable this account (that i'm logged into) on my old phone?
Do not "disable this account" on the old iPhone. Instead, simply log out of your iCloud account there.
What to do before you sell or give away your iPhone, iPad, or iPod touch - Apple Support
INeedHelpPlease🇬-1F1E7; wrote:
will this mean my new phone will be synced onto my mac?
You must take some overt action (e.g., plugging the new iPhone into the Mac using a USB cable) to sync the new iPhone to the Mac. The Mac must have iTunes 12.7 or later to communicate to iOS 11.
INeedHelpPlease🇬-1F1E7; wrote:
will it also mean all my photos will leave my iCloud library?
Photos don't "leave my iCloud library" unless you direct them to leave; e.g., erase them. If the photos are housed in iCloud Photo Library and you want them on the new iPhone, then turn iCloud Photo Library "On" in Settings > Photos > iCloud Photo Sharing on the new iPhone.