How do you cancel iCloud storage charge on old phone.

The storage charge is related to your Apple ID, not to a specific device. To cancel, downgrade to the free 5GB level. See: Downgrade your iCloud storage - Apple Support

Yoy can change the storage by going to Settings --- Icloud --- Icloud again --- Manage storage --- Change storage plan and you can change the play to whatever you want to change it.