How to transfer photos from iPhone to mac

If you want to sync all photos between your iPhone, your Mac and iCloud (both directions) you only need to turn on iCloud Photo Library on both devices, although the other options won't hurt anything. In my experience the initial sync can be very slow but after that it is very responsive.

More information on iCloud Photo Library: iCloud Photo Library - Apple Support

If you leave iCloud Photo Library turned on in both devices, any new photos and any other changes (edits, deletions) will automatically sync to both and to iCloud.

See: Transfer photos and videos from your iPhone, iPad, or iPod touch - Apple Support

You haven't given any information about which method you are using or how long it has taken. If you are using iCloud Photo Library, it can take awhile.