Let's check. First, on your computer open System Preferences, iCloud. Verify that the Apple ID that is displayed is yours and that Photos is On. Then click on Options next to Photos and verify that iCloud is checked. On your computer do you see all of your photos when you open the Photos app?
Next log in to https://icloud.com using the same Apple ID and go to Photos. Do you see exactly the same photos you saw on your computer?
On your iPad Open Settings, tap on your name, then iCloud. Is it the same Apple ID? Is Photos on in iCloud settings? Then go to Settings/Photos. Is iCloud Photos on? Is Photo Stream off? Do you see your Photos in the Photos app?
On your iPhone Open Settings, tap on your name, then iCloud. Is it the same Apple ID? Is Photos on in iCloud settings? Then go to Settings/Photos. Is iCloud Photos on? Is Photo Stream off? Do you see your Photos in the Photos app?
Which of these are not working?