Is Two-factor Authentication turned on for your iCloud account? Perhaps you may need to add your new number into your secured account and delete the old one.
"If your iPhone is your only trusted device and it is missing or damaged, you will be unable to receive verification codes required to access your account.
You can update your trusted phone numbers when you follow these steps:
- Go to your Apple ID account page.
- Sign in with your Apple ID.
- Go to the Security section and click Edit.
If you want to add a phone number, click Add a Trusted Phone Number and enter the phone number. Choose to verify the number with a text message or automated phone call, and click Continue. To remove a trusted phone number, click next to the phone number you want to remove."