iphone x or iphone xr?

The X has dual cameras, portrait mode not just limited to faces, oled, last years processor and stainless build.

The Xr has latest processors, single camera, lcd, portrait mode limited to faces (although some third party apps have changed that) and aluminium build.

The Xr is slightly larger.

In my view it comes down to your preference, “speed” v “features”.

Like most decisions of this type you really need to compare them in the flesh so to speak.

The X is last year's model, the Xr is a current model, though lacks the dual camera of the X and Xs.

See here for a specific comparison: iPhone - Compare Models - Apple

Then go with X.

The X has been discontinued, so if you’re buying new, at least get a current generation device.