Cannot see iPhone photos on Mac iCloud is set up

See this article https://support.apple.com/en-in/guide/photos/pht5156cc968/4.0/mac/10.14

In Mac open system preferences > iCloud the box of photos is to be checked , click on option button do the settings as per screen shot .

Follow these articles https://support.apple.com/en-in/HT204264

https://support.apple.com/en-in/HT201313

Before you begin

1. Update your iPhone, iPad, or iPod touch to the latest iOS, your Mac to the latest macOS, and your Apple TV 4K and Apple TV HD to the latest tvOS.
2. Set up iCloud on all of your devices.
3. Make sure that you’re signed in to iCloud with the same Apple ID on all of your devices that you want to use with iCloud Photos.

Open photos application and then its preferences , follow the settings as per screen shot .

The following is all that you should need to do for all of the photos on both devices (using the same Apple ID for iCloud) to sync to iCloud and to each other:

On the iPhone, turn on Settings > [username] > iCloud > Photos > iCloud Photos (and possibly also "Optimize iPhone Storage" if you want to reduce the space required on the iPhone).

On the Mac, Apple menu > System Preferences > iCloud > Photos - Options > iCloud Photos.

No other settings are needed, iCloud Drive is not involved, and the sync should start automatically. Note that it can take a long time especially if there are a large number of photos. Also note that you may need to buy more iCloud storage, depending on the size of your photo library and what else you have on iCloud.