All the icons on my desktop files arent showing since Catal

Hello Chasbol,

Thanks for visiting the Apple Support Communities and asking about your desktop icons since upgrading. I believe you inadvertently enabled Desktop and Documents in iCloud.

This article has the info, and screenshots to help: Add your Desktop and Documents files to iCloud Drive - Apple Support

It also includes how to turn this off. Make sure you turn this off first, and then you can move the files from iCloud back to your Mac Desktop and Documents folders.

"Turn off Desktop and Documents

When you turn off Desktop & Documents Folders, your files stay in iCloud Drive and a new Desktop and Documents folder is created on your Mac in the home folder. You can move files from iCloud Drive to your Mac as you need them, or select all of your files and drag them to the place you want to keep them.

1. From your Mac, go to Apple menu  > System Preferences > iCloud.
2. Next to iCloud Drive, click Options.
3. Deselect Desktop & Documents Folders.
4. Click Done."

"On your Mac

You can find the files on your Desktop and in your Documents folder in Finder under iCloud. You can also search for the titles with Spotlight.

You can organize and combine folders from multiple Macs when you turn on Desktop and Documents on those computers too. After you turn on Desktop and Documents on a second Mac, you'll find its files in folders with the same name as your second Mac inside your original Desktop and Documents folders. Then you can combine your files manually, but iCloud doesn’t automatically merge the files in case you want to keep them separate. Any edits you make are seamlessly updated in iCloud Drive. There’s no need to manage your folders and files again on your other devices."

Thanks and have a wonderful day.