right click no longer working

You might try going into Safari prefs (click Safari name up in left corner of screen by Apple icon, scroll down and select preferences) and go down to Download Location. If it's on "ask for each download", click on it and change it to where ever you want downloads to go. Looks like this:

I'm sorry, you are speaking of right clicking on links it sounds like. A right click on a link is "contextual", that is, it depends on what you are clicking on as to what options you"re given. If you click on a link that can be downloaded, you will get a menu to allow said download. If you click on a link to another web page, it will give you options to open new tab, new window, etc. Not sure I'm understanding the part about opening Safari prefs and getting download window. Does it look like this?

Does it work in other apps or folders? What kind of mouse/trackpad are you using? Try holding down control key while left clicking to see if that brings up a contextual window. You may just need to reprogram your mouse/trackpad for right key to give the control-left click function.

You're welcome! Glad I could help. The File download location pref allows users to customize where they want their downloads to go. Some users have different folders for different kinds of downloads, such as apps, fonts, documents, work, etc. Some users like myself just dump every download into the Download folder and then sort them out.