Hi I upgraded to 200 gb plan but it keeps saying my storage is full

Why is your storage high? If you have a high "Other" setting this could be data/storage corruption. I've attached more information below:

"Other" includes system files, caches, Siri voices, logs and updates - this can often be high but it seems it is much higher than it should be for you, I want to help you fix that. It sounds like you have some form of memory/storage corruption. If I was you, I'd back up my phone to iTunes with the steps at https://support.apple.com/en-gb/HT203977 before erasing my device and restoring it with that back-up which hopefully should fix that.

Storage on your iPhone is not the same as iCloud storage

https://support.apple.com/en-us/HT201656

Also optimizing photo storage on your iPhone can help a lot

https://support.apple.com/en-us/HT205703

iCloud storage does not add storage onto your device. Your storage is full notification is likely talking about your device. You can not pay to add storage to your device.

You can Go into Settings > Photos > Optimise iPhone Storage

This will keep your photos on your device in low resolution but keep originals in iCloud.

Go into General > iPhone Storage. Can you upload a screenshot for this so we can make advise you how to get your storage down further to free up space?

Optimise Photo Storage as shared by mullberry58 will allow you to store high quality resolution photos on iCloud, while keeping the lower resolution photos on your phone. This will help free up some space.

It's possible that message is referring to your on-device storage being full, not iCloud.