PDFs on iPad not on iPhone

Simply turning on that setting won’t automatically move your existing PDFs to iCloud Drive.

It would house future PDFs there. Or you can attempt to overtly move your existing documents there.

Set up iCloud Drive - Apple Support

Because you’ve chosen not to share them.

To share them, set:

Settings > Books > iCloud Drive = “on” on all your Apple devices.