Why are my photos not being shared between devices using family sharing?

Family Sharing doesn't automatically share all photos but you can select photos to be shared by adding them to the shared album. See the following from Family Sharing - Apple

When you set up your family, a shared album is created automatically in the Photos app on all family members’ devices. Everyone can add photos, videos, and comments to the album whenever they like and get notified when something new is added.