duplicated folders

NO NO NO. (sorry for shouting)

These are the folders INSIDE your photos library, where photos stores the images. Do not change ANYTHING inside the photo library if you don't want to lose access to all your photos.

(your library is : /Users/barryhodges/Pictures/Photos Library copy.photoslibrary)

If this is a COPY of your actual library - then you can delete the whole library - but before you try this be VERY sure that it is a copy, and not the one being used by photos.

To be honest, I'm surprised spotlight is even showing these to you.

Yes, try a new unused library - no icloud - import some photos. See if that works.

If it works with imported photos, but an iCloud sync stops it working then I don't know (unless the iCloud sync is not fully complete which if your library is large can take some days).

The Photos Library has no user-serviceable parts. Removing or changing anything inside it runs a strong risk of damaging the library beyond repair.

When you click in facebook to add a photo, don't use those folders.

Instead - scroll down in the left hand side bar to the media section, and click on photos there:

Then you will be offered photos that are stored in your library.

If your backup is time machine, you should be able to restore from a date before you made any changes.

If you have manually backed up by copying the library package to an external drive, then whether you have backed up the mistakes or not will depend on when you last copied the backup, and if you kept any earlier versions. In either case, you don't NEED to buy a new mac here, whatever you can restore from backup can also be fixed in your current machine.

That doesn't mean you shouldn't use this event as a perfect excuse for some shiny new hardware (with more storage) though :-)

PS - is your professional familiar not only with Macs, but how macs manage their photo libraries? He needs to be if he is going to give you good information.

What is the file format of the photos?

Are you taking the photos with an iPhone or iPad in the space saving High Efficiency format? You can see this in the Settings > Camera on the iPhone.

Most of the photos in the HEIC format cannot be uploaded using the Media Browser. Only , when I edit them and add some adjustments and Photos has created a preview, will they be visible in the Media Browser for upload.

When I look at my Photos Library using the Media Browser, most of the images are greyed out - all photos in the HEIC format, that do not have adjustments applied. This started with with the most recent version of macOS 10.15 and persists in macOS 11 Big Sur.

So, please check the image format of the files in your library. Are they JPEGs or HEIC, or another format?

In my Library I emceeing this in the Media Browser: The images with white filenames have been edited and have a JPEG preview, the other images with grey filenames do not have adjustments applied and do not have a JPEG preview and cannot be selected when uploading.

Assuming it is a problem with your account. Your simplest solution may just to be to set up a different user account for you, and copy stuff from old to new account as you need to.

Trying to diagnose the actual problem will probably take more effort.

It is not possible to uninstall Photos separately. Photos is a part of the system, just like Mail and Contacts. To reinstall Photos you reinstall the system, but only, if you are sure that the problem is system wide and not caused by a damaged Photos Library.

How have you tested in the new user account? Did you test with a new Photos Library in your new Home folder, or did you try to open your old photos Library? Testing in a new user account will only tell you if the system is damaged, if everything is new - a new account, all the basic system preferences, and a new, empty photos library, with new test images imported to the library, and no third party start-up item active.