Why is my iPhone charging indicator showing yellow instead of green?

Because you have enabled the Low Power Mode option.

HJMartin wrote:

thank you, I hadn’t realized that option was selected. 👍😊

It will turn on automatically if your state of charge drops below 20%.

You are quite welcome.