will erasing all data from old phone delete it from new phone

It depends on the way you erase it. Sign out

Remove your personal information from your old device

1. If you paired an Apple Watch with your iPhone, unpair your Apple Watch.
2. Back up your device.
3. Sign out of iCloud and the iTunes & App Store. 

• • If you're using iOS 10.3 or later, tap Settings > [your name]. Scroll down and tap Sign Out. Enter your Apple ID password and tap Turn Off.
  • If you're using iOS 10.2 or earlier, tap Settings > iCloud > Sign Out. Tap Sign Out again, then tap Delete from My [device] and enter your Apple ID password. Then go to Settings > iTunes & App Store > Apple ID > Sign Out.

1. If you're switching to a non-Apple phone, deregister iMessage.
2. Go back to Settings and tap General > Reset > Erase All Content and Settings. If you turned on Find My [device], you might need to enter your Apple ID and password. If your device uses eSIM, choose the option to erase your device and the eSIM profile when asked.
3. If asked for your device passcode or Restrictions passcode, enter it. Then tap Erase [device].
4. Contact your carrier for help transferring service to a new owner. If you aren't using a SIM card with your device, you can contact them to get help transferring service to the new owner.
5. Remove your old device from your list of trusted devices. (optional)