Can I buy storage without credit card?
Can I upgrade iCloud storage without credit cards?
iPhone 6, iOS 12
You can add funds to your Apple ID so that the money will be taken from there, but you have to have a credit card on file because iCloud storage is a subscription.
Buy/redeem Apple Gift cards to the account.
App Store & iTunes Gifts - Resend
Or