If I share my storage with someone can they see my photos
Sharing storage can others see my stuff than pictures,emails,ect.
iPhone 12 Pro Max, iOS 15
Question marked as
Are you asking about the Family Storage plan where up to six people can share an iCloud Storage Plan? The answer is no, each person's contents are private. You can permit others to view a shared photo album you create for that purpose, but they have no connection to your collection otherwise.
Apple takes the opportunity to address exactly that in the linked Family Storage plan webpage:
Everyone's personal files and preferences remain private
When you share iCloud+, family members can't see each others’ photos, files or documents. And when you share other subscriptions, such as Apple Music, Apple Fitness+ or Apple TV+, each person will see their own preferences and recommendations – not the whole family’s.