I renewed my Apple Music subscription hoping to get all my old music back but when I go to sync back to iCloud nothing happens how do I get my music back?!

I decided not to take the Music service after my free 90 day trial. I had some of my personal albums copied to my new iPhone and then synced with my new MacBook Air. Now both devices have removed my personal music files. I owned those music files and I still have them on my PC, but Apple seems to think they own them seeing I am using them on their device? Maybe the VLC app will work on my Mac products, but this seems a violation of my rights, not a licensing issue.

You only lease music with an Apple Music subscription. Once you cancel your subscription or let it expire all that music goes away and there is no way to retrieve it. Sorry, but you will have to start from scratch.