I’m trying to get my pictures from my old iCloud address and I’m not finding them

Thanks for visiting the Apple Support Communities, vernalisa68,

How you get photos from iCloud depends upon how they were shared with iCloud:

1. If you're using iCloud Photos, sign into the Apple ID associated with the pictures on any Apple device, using iCloud for Windows, or by visiting iCloud.com on a computer browser. The below resources discuss the ways you can get the photos form there:

• Set up and use iCloud Photos - Apple Support
• Download iCloud photos and videos - Apple Support

2. If you're not using iCloud Photos but did back up an iOS device to iCloud, you can restore a backup to another

iOS device following Restore your iPhone, iPad, or iPod touch from a backup - Apple Support. If your pictures were on your device at the time of the backup, they will be accessible on the device after you restore the backup.

This process will replace all the current data on the device with only the data that was on it at the time of the backup. We recommend creating a current backup before restoring the old on. This will prevent loss of new data: How to back up your iPhone, iPad, and iPod touch - Apple Support

Have a great day!