If you remove the device from your iCloud while the erase command is still pending, it could potentially prevent the device from being erased. This means that your data may still be accessible to the person who bought the phone.
To ensure the security of your data, it's generally recommended to wait until the erase command is completed before removing the device from your iCloud account. Once the erase process is finished, all the data on the device will be permanently deleted, making it inaccessible to anyone.
If the buyer has already fixed the phone and is requesting you to remove the device from your iCloud, it's advisable to communicate with them and explain the situation. You can ask them to ensure that the erase process is completed before removing the device from your iCloud account. This way, you can be more certain that your data is securely erased.
It's important to note that the exact behavior and options available may vary depending on the specific circumstances and device settings. If you have any concerns or questions, it's recommended to reach out to Apple Support for personalized guidance and assistance based on your situation.