Why does my payment method not work

Whenever I try to upgrade my iCloud space, it asks for my payment, which I make, then it says I need to update my payment method, which I thought I did, but it still won't work. Why does this keep happening? How do I update my method?