I have often had sync problems syncing from Mac Photos library via USB to an iPad.
Sometimes many random images fail to arrive to the iPad, sometimes they arrive as blank images on the iPad.
I have tried almost every voodoo. Reboot before syncing. De-select an updated album on the Mac Photos, sync, re-select that album and sync again. Don't launch or launch Photos and keep it in the background on the Mac while syncing. etc. To make matters worse is that doing a seemingly small album update and then syncing a 400 GB library containing 35 000 images and hundreds of movies is slow and sometimes stalls and often hangs up to 1-2 hours in the end.
Lately, when all else fails, I have taken drastic measures and deleted Photos library/iPod Photo Cache -folder and it has worked for me. But if you try that, make good backups and do not edit any other files inside the library folder! I have all images elsewhere so it is no disaster if the library happens to corrupt.