Do I need an appointment to buy an iPhone with trade in at Apple Store?

No, it’s not required. However, due to the holidays, stores will be very busy. An appointment will speed things up. However, if you’re not in a big hurry, they’ll get it done.

No.

In fact, most stores are not even accepting appointments now except for Vision Pro.

Not in most countries, no.