Photo edits are not syncing with iCloud Photos

Do you have a backup of your Mac Photos Library? If so, you could try rebuilding your Library to see if that helps:

close Photos and re-launch by option-command-clicking the app icon.

Or, if rebuilding doesn't work, you could just make a new fresh Library and fill it with your pictures from iCloud.

I'd create a new Library (close Photos, option click the Photos icon, and choose Create New from the Library dialog:)

Then make the new empty one the System Library at Photo's Settings>General:

(Here, "Use as System Photos Library" is grayed out, because this one already is.)

Then connect this new empty System Library to iCloud with Photo's Settings>iCloud:

I always have "Download Originals" checked for my Mac, but you may need to choose "Optimize" if you don't have enough room.

Then wait for this new Library to download all your pictures. This probably takes a few days, but you will be sure that none of the files have been corrupted.

After you're sure you've gotten all your pictures, you can ditch the old one.

When you go to the bottom of your Library on your Mac, what does it say about syncing? Mine looks like this:

It sounds like it's not the phone's fault, but just in case: In Photos on in iOS 18 on an iPhone, in the upper right corner, is the Apple ID picture. If I click on my ID icon, I get this:

showing that it has synced just now. (This screenshot is a different time that the other one, so they don't quite match.)

What do you get?

How is the storage on your Mac? Mine says about 756 GB of 1000 GB used.

Picture edits are recorded in steps in the Photos database, so they normally sync pretty quickly. I just make a clean up edit on my Mac, and it showed on my iPad in maybe 2 minutes.