BUT My iPhone 16pro still shows SIM locked.
ATT might have told you that the phone was unlocked, but it is not unlocked until you see a message of No SIM Restrictions instead of SIM Locked.
Just did a reset all settings and that didn't work.
This will never work. Only ATT can unlock the phone. Apple has nothing to do with this.
I am scared to go to factory settings just to unlock.
This will never work either. Only ATT can unlock the phone. Factory settings will not unlock the carrier lock on the phone.
Ask for a senior support person when you call ATT back again. For the most part, the new hires are not really going to be able to help you. They will use some excuse like it might take a few days, or Apple needs to get involved (nonsense).ATT is hoping you will give up and stop calling, because they realize that they are likely going to lose a customer otherwise.