If I put my sim into another upgraded iPhone will my data move with it

None of your data is stored on the sim. Just info needed by the carrier.

Hello!

If you are talking about contacts and photos, no they will not be stored or transferred on the sim card. Everything is stored in the iPhone and iCloud.

Hope this helps!