Why aren’t my messages popping up on my new phone from my iCloud?

There are a number of factors this is happening. My first question though is, have you enabled iMessage for iCloud? Go to Settings > Your Apple ID (the one at the top with your name) > iCloud > then see if Messages is turned on. If not, then you will need to turn these both on your phones and wait for them to sync.