Hello ZohaibQayyom,
Thanks for your post to Apple Support Communities. You mentioned your MagSafe Battery Pack isn't charging properly. We'll be looking at this guide:
How to use your MagSafe Battery Pack
Make sure you are using an Apple-branded cable and power adapter. You'll need to use a 20w power adapter to charge it. Test it with different cables and power adapters. Check the port on the MagSafe Battery Pack to make sure no dirt or debris is in it.
Also, you can plug a cable into the MagSafe Battery Pack then have it attach to your iPhone to charge both at the same time. See if either way works (charging the battery pack on its own or with your iPhone).
Reply back with how it goes.
Take care.