Photos crash and launched terminal window, what's going on?

We just upgraded a 2014 iMac to run Big Sur. Things are mostly running smoothly but just got the following problem while editing an image. Photos appeared to crash then the following terminal window appeared, followed by the dialog window. Both shown below.

Anyone know what's going on here and what we need to do (if anything?) Photos is making me very nervous lately, would love not to lose too much work.

I did go to the support page listed, I see instructions on changing the "interactive shell to zsh" .. is that what I need to do? Seems like a lot more going on here, no?