I have visa debit card attached but it keeps failing for payment for upgrading my iCloud sub

Hi bushrafromsascot,

This Apple Support article outlines the steps you should take when your payment is declined. Note that you will need to add a different payment method and remove the old one to address any outstanding balances.

How to complete your purchase if a payment failed or was declined

1. On your iPhone or iPad, open the Settings app.

2. Tap your name.

3. Tap Payment & Shipping.

4. Add a different payment method and remove the old one. 

5. Try to complete your purchase.

If your payment method is declined in the App Store or iTunes Store - Apple Support

The Apple Support Communities are a place where you can connect with other Apple users. If you need to speak to a live person from the Apple Support team, please reach out to them here:

Contact - Official Apple Support

Kindest Regards.