hi, my iPhone is not showing up on photos on my Mac. I have restarted both devices and they are connected to the wifi.

Unless you use AirDrop, WiFi isn't going to move the photos. Much faster, is just to connect a charging cable to your computer. That will ask you if you want to import any new photos.

Use AirDrop on your Mac - Apple Support

How are you syncing photos between your iPhone and your Mac?

With the Finder (in Catalina or later)?

Use the Finder to sync your iPhone, iPad, or iPod touch with your Mac - Apple Support

With iTunes (In Mojave or earlier)?

Use iTunes to sync your iPhone, iPad, or iPod with your computer - Apple Support

With Image Capture?

Transfer images in Image Capture on Mac - Apple Support

With iCloud Photos?

Set up and use iCloud Photos - Apple Support

Presumably you are not using My Photo Stream. (It made photos taken on one device temporarily available, in lower-resolution form, to other devices.)

It's shutting down very soon (having been replaced by iCloud Photos), and all new uploads to it stopped as of June 26, 2023.

My Photo Stream - Apple Support

Information about the My Photo Stream shutdown - Apple Support