I'm having similar issues when syncing my iPhone 15 (iOS 17.2.1) with a MBP 2018 (Sanoma 14.1.2). First I thought the syncing issues were only with my 10.2" iPad, but now issues exist when syncing my iPhone too (possibly after upgrading from 17.2 to 17.2.1 but I can't be sure).
I must add that I am able to get a successful sync after multiple tries, but I've yet to figure out what really works.
When syncing, I normally skip the backup, but when my MPB keeps displaying 'preparing to sync' form longer then 15/20 min, I usually cancel the syncing process and retry. This normally results in the syncing process seemingly completing, but then my (new) photo's aren't synced.
When this happens, I sync again and if my photo's still aren't added, I click sync again, but this time not skipping the backup. Still not successful? Then I try restarting my phone. If that doesn't result in a successful sync, I restart the Mac, too. Of course, I also try another port or another cable.
The kicker is that sometimes the first sync just works. But on my iPhone 15, this might have been when backup was included AND a previous backup was present in ~/Library/MobileSync/Backup
On my previous iPhone syncs rarely had issues.
A couple of years ago (I think somewhere around iPadOS 13), I had sync issues for a while with only my iPad that were solved after an iPadOS update that apparently fixed the problem.
Lets hope OS 17.3 does this too.