My iPad notes don’t sync with my iPhone notes

Are both devices signed-in to iCloud with the same AppleID? Assuming that both devices are using the same AppleID, ensure that you have enabled iCloud Notes for both devices:

Settings > [Your Name / AppleID] > iCloud > [App Using iCloud] Show All > Notes > Sync This iPad | iPhone - set to ON