I'd like to put to bed the notion that this issue is (for most people here) an internet speed issue. We are all well aware that uploads will take a while. So far I've pushed up about 300GB into my iCloud Photos library. I've anticipated the internet slowness that will come with it. I'm quite knowledgeable in this field, as I'm working with networks day in and day out.
The symptom that I am seeing is nearly identical to other users here, and I've been troubleshooting it for days thinking that my cable modem just was going out, though it's a fairly new SB6120. I'm curious if the others that are running into this issue are using the same model modem. What seems to happen is one of 2 things:
1. Cable modem stops passing traffic to ISP gateway. In this state I can reset the modem by using it's web interface and rebooting the modem.
2. Cable modem stops answering all requests. Wont respond to ping, will no longer respond to web requests for its status page (http://192.168.100.1). In this state, I need to physically power cycle the modem for it to return to a functional state.
This has never happened previous to the iCloud photo library upload. I have a WatchGuard firewall in place, that I initially suspected was somehow blocking the traffic due to its advanced scanning and blocking features, but I've disabled nearly everything in this troubleshooting process to no avail.
All the lights on the modem remain on in a normal state of operation, so the cable modem itself believes it's still online. My guess would be that there's something with the packets that's locking up the cable-ethernet bridge in the modem, though the logs in the modem don't seem to be reporting anything out of the ordinary (which usually only logs the cable/WAN side anyway from my experience). This issue may completely be in the modem, but just triggered by something Apple is doing in their upload. Or it may have something to do with the ISP's system possibly blocking suspicious traffic.