This is my situation and my provisional solution.
GPS failed on my iPhone X.
I tried resetting networks, restarting, fiddling with Location Settings etc etc but nothing worked.
So, I factory reset it, took it to the Apple Store, and got a replacement.
That resolved my problem.
However, I was never sure whether it was the factory reset or the phone replacement that fixed the problem.
Yesterday, GPS failed again.
Today, I tried something different. This may prove to be my personal eureka moment (please note: I fully accept that other people can have hardware problems). If this solution works, it would back up Rollier's theory that the issue —in our particular cases at least— concerns Cellular Networks. Anyway, this is what I did:
1. Turn all apps off.
2. Remove SIM card while phone on.
3. Shut down phone (volume button and sleep button for iPhone X).
4. Restart phone while SIM card out.
5. After phone restarts, push SIM card in.
6. Open GPS Diagnostics, or any other GPS app to test, and Hey Presto, it works!
I will let you know if this is just a fluke.