This is what worked for me.
Issue started after I changed my plan with ATT and rebooted a few times. Didn't want to lose the contacts or the years of SMS I've been collecting as an information hoarder. Spent two days on the interwebbernets looking for the definitive answer and trying different things. This worked - for me - and has stuck for a few hours:
1) Settings -> Messages
1) Send and Receive -
Turn off all addresses except phone number.
Turn off iMessage
2) Settings -> Phone
1) My Number
- Delete the phone number that is in this field.
3) Reboot phone
1) I didn't do hard reset, hard powerdown, none of that. Just vol down and side button until "power off" option, then once it was off for about a minute turned it back on.
4) Settings -> Messages
1) Turn iMessage back on.
2) wait a few seconds. Can back out of menu and come back in. Want to make sure it's no longer "waiting for approval"
3) Adjust "Send and Receive" to what you want it to be
- I receive at a few places, only send from phone number.
- You will notice that there IS a phone number again.
5) Reboot iPhone - see step 3. Nothing funky here.
Viola - I tested with my droid buddies and no longer see the message.
This was all done on iOS 12.2 on a XS Max 512.
~D