how do you share a photo album

I have a family iCloud subscription and I would like for our family's photos from our phones to all upload into a single location where they can be accessed by everyone. That was really the only reason I got the plan, but it's not working. It seemed to be working as my large library on my computer synced to my phone, and I can now access over 30,000 photos from my devices, but my wife doesn't have access. She has an entirely different photo library on her phone and computer now with duplicates, and each new photo she takes only goes to her phone and laptop. Likewise, every new photo I take goes to my phone and laptop only. This is not what I was trying to set up. Anyone got an idea? I've hunted for a solution, but all the settings I am told to check when I search are set correctly. Frustrated.