Update on this.
After awful GPS accuracy with iPhone X under iOS 12, as reported I got a small improvement in October but certainly not back to the accuracy I experienced before iOS 12, and only on certain days (implying it could well be an acquiring GPS signal issue).
Since then I have tried (for running GPS purposes) the Fitbit Ionic and Garmin 635 (both standalone GPS watches that don't require a smartphone) and had poor GPS and other issues on both. I then held my nose after all Apple's problems and got a Watch 4.
The AW4 has been flawless for GPS - I'm amazed. Not one mistake the past 3 weeks, and I'm not spending any time to acquire a signal either (it's often 5.30am and 3 degrees so I don't hang about). So it's all the more unusual that GPS in the iPhone X is way off.
Surely GPS tech is comparative between AW4 and iPhoneX and if anything more high powered in the smart phone. This leads me to be more certain this was a software issue introduced with iOS 12 on the phone (although Apple continue to refuse to address it).
Anyway, since then I've continued to do a few more tests with the iPhone X as I still get hopeless GPS even with local search apps or things like Citymapper. I use a standalone GPS tracking app ("TrackMe") and the tracking, anywhere in London, is a mess.
Finally, today for separate reasons, I carried my iPhone during an AW4 run. Amazingly, first 1km on the watch reverted to the awful accuracy (c.10-15% out). I guess if the phone is near it uses its GPS. I turned the phone to Airplane mode and GPS was fine.
What more can I do to prove to Apple that GPS issues occurring on the iPhone relate to its software, and its software alone....??!!