Works now - more or less
Had the same issue and kept updating macOS and iOS and kept changing Photos Album structure and synchronisation level.
Photos library includes >25.000 pics, > 1000 videos and >100 albums, folders and subfolders
Run now macOS 10.15.1 and iOS13.2 on iPhone6s (126Gbyte and still lots of free memory space)
After missing all pictures in all album subfolders on the iPhone after synchronisation and numerous try's and changes I think what worked was to deselect in /finder/Locations/iphonename/Photos 'Sync photos to your device '
and accept with synchronisation to delete all photos on the iPhone. It needed several syncs and patience until the photo library on the iPhone was finally really deleted.
Then I selected the 'Sync photos to your device', while limiting it to 'selected albums' only.
With the first sync I started with Favourites only, the started adding the next albums to come after each sync like videos, selfies...
Then I started using to include first albums, folders and subfolders. This still did not work necessarily the first time, but started to work after a few syncs.
Then I switched to sync 'All photos and albums'. Took a long time. After first sync the iPhone did show a lot of picture frames that stayed black. So it knew about the pictures, but did not seem to have a preview....
After a couple of further syncs I finally had the full library, all pictures and all videos synced with all albums, folders and subfolder structures!
However it is still not a stable solution. With next sync there are suddenly 6000 pictures missing again. After importing one new picture from the iPhone to make it force to synchronise and a new long resync they are all back again.
So it does work from time to time, but is still not stable.
From my perspective this has nothing to do with iCloud or local sync. This only has to do with software quality and the prioritisation of bug fixes.
Synchronising a list of pictures is not rocket science. It does not require artificial intelligence nor quantum computing. This did work fine already 5 years ago. It also does not need a lot of processing power.
My guess is that the company spends much efforts in new features like face recognition and creating moments for you that might not be needed by every body, while loosing the quality and stability of must have basic features.
All the automatic picture processing in the background for these features takes tremendous processing power and still offers only limited results. Thats why I keep doing the face recognition and creating 'moments' (album/folder/subfolder) by myself.
With this unstable synchronisation of deleting and resending thousands of pictures the phone keeps rescanning the same pictures for face recognition again and again and synchronisation takes forever.
So while we hope for a new release to get basic features back to work, lets hope no other working features get corrupted.
Back to future
Then I startet with 'Se